Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561470

Terje Røsten <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #19 from Terje Røsten <[email protected]> 2010-04-13 17:34:14 
EDT ---
Some pedantic stuff:

 o why start release with 0 and not 1?
 o remove trailing ; here: 
   %clean
   rm -rf $RPM_BUILD_ROOT;
 o add a comment why %build is empty
 o use INSTALL='install -p' in make install to preserve timestamps
 o it's very common to have documentation in %{_docdir}/%{name}-%{version},
   any reason not the follow that?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to