https://bugzilla.redhat.com/show_bug.cgi?id=854849

--- Comment #14 from Tomas DabaĊĦinskas <[email protected]> ---
Russell, 
thanks for your feedback, I have looked at the packaging guidelines and your
spec. I'm basing my spec on yours[1]. With regards to the tests, I have noticed
that tests pass if called via shell:

$ testrb -Ilib
/home/makerpm/rpmbuild/BUILDROOT/rubygem-taskjuggler-3.3.0-2.el6.x86_64/usr/share/gems/gems/taskjuggler-3.3.0/test
Run options: -Ilib

# Running tests:

............................................................................................................

Finished tests in 88.454893s, 1.2210 tests/s, 2962.4704 assertions/s.

108 tests, 262045 assertions, 0 failures, 0 errors, 0 skips

I have removed 2 tests that fail on rpmbuild from the spec. I have also changed
rspec test definition. Please have a look at the package[2] and let me know
what you think.

[1]
http://pkgs.fedoraproject.org/cgit/rubygem-taskjuggler.git/commit/?id=8b84daef0eab8ac78057c30941698349dfdda733
[2]
http://kojipkgs.fedoraproject.org//work/tasks/4418/4624418/rubygem-taskjuggler-3.3.0-3.fc19.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to