https://bugzilla.redhat.com/show_bug.cgi?id=852174

--- Comment #12 from Ondrej Kozina <[email protected]> ---
I have assembled new spec file. Snapper is updated to the latest commit in
master branch and patched to reflect the bug discussed here and also few
others.

(reported upstream):
- patch: avoid abrt when 'diff' command is executed without arguments
- patch: do not check for btrfs-progs binary
- patch: do not allow 'create-config' command on non-thin LVM volumes

Also, I have removed python bindings since python users can communicate
directly with snapperd via dbus interface.

Removed both btrfs-progs and LVM direct dependencies. LVM has been discussed
here and btrfs-progs are not needed anymore. Snapper's been rewritten to call
directly ioctl instead.

(In reply to comment #10)
> Also, I'd probably add EXAMPLES section to the snapper man page so people
> can quickly see what to do to create a simple snapshot scheme - just for
> convenience.
> 
> As for functionality itself:
> 
>   (/mnt/temp1 is not mounted!)
>   [0] rawhide/~ # snapper create-config -f "lvm(ext4)" /mnt/temp1
>   Creating config failed (invalid filesystem type).
> 
> - maybe a better message to explain that /mnt/temp1 is not mounted at all
> and so it can't create a snapshot in this case (as snapper is targeted for
> mounted volumes only)

this will require a change in error reporting design of snapperd so this'll
take some time, I suppose. Anyway, I'll report that with some patch proposal
soon.

Spec URL: http://okozina.fedorapeople.org/snapper/0.1.0/1/snapper.spec
SRPM URL:
http://okozina.fedorapeople.org/snapper/0.1.0/1/snapper-0.1.0-1.20121026git1aaa372.fc19.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to