https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #16 from Mohamed El Morabity <[email protected]> --- > 4) DON'T pipe sed through cat, it's useless, unreadable and considered bad > practice. Simply use sed only instead: > > for FILE in bin/*; do > if [ -f $FILE -a -x $FILE ]; then > sed -e "s;^GOGUI_LIB=.*;GOGUI_LIB=\"%{_javadir}/%{name}\";" \ > -e "s;^JAVA_DEFAULT=.*;JAVA_DEFAULT=\"$JAVA_DEFAULT\";" \ > > $RPM_BUILD_ROOT%{_prefix}/$FILE > chmod a+x $RPM_BUILD_ROOT%{_prefix}/$FILE > fi > done Mistake, use this instead: for FILE in bin/*; do if [ -f $FILE -a -x $FILE ]; then sed -e "s;^GOGUI_LIB=.*;GOGUI_LIB=\"%{_javadir}/%{name}\";" \ -e "s;^JAVA_DEFAULT=.*;JAVA_DEFAULT=\"$JAVA_DEFAULT\";" $FILE \ > $RPM_BUILD_ROOT%{_prefix}/$FILE chmod a+x $RPM_BUILD_ROOT%{_prefix}/$FILE fi done -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
