https://bugzilla.redhat.com/show_bug.cgi?id=875406

--- Comment #5 from [email protected] ---
Hi Ken, thanks for the thorough review.


I'd like to build for EPEL but for the time being don't really understand
what's involved and have some reading up to do first which is mostly limited to
weekends.  For the purpose of this discussion, assume I won't be building for
EPEL.

If you can give me some pointers about which bits are EPEL specific that would
be great information.

I take your point about a module being loaded but not used causing dependency
creep.  In this particular case, Data::Dumper is part of the core perl package,
so there's no additional dependency that gets added in this instance.  It does
show that you are thorough in your review, and that I appreciate, as it leads
to better quality.  Eg,
------------------------------------------------------------------------
yum provides "perl(Data::Dumper)"
Loaded plugins: langpacks, presto, refresh-packagekit
4:perl-5.14.1-188.fc16.x86_64 : Practical Extraction and Report Language
Repo        : fedora
Matched from:
Provides    : perl(Data::Dumper) = 2.130
------------------------------------------------------------------------


Finally, your point about updating the release number is valid, if that's ok
with you i'll do it going forward when I need to change the .spec file ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to