Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=875299

--- Comment #4 from Fabian Affolter <[email protected]> ---
Thanks for your informal review.

(In reply to comment #2)
> - In %setup you can use '%setup -q -n %{name}-%{version}'

Well, there is no benefit from using '-n %{name}-%{version}' in this case
because '-n %{name}-%{version}' is the default.

> - According to Licensing Guide Lines [1], if the source package includes the
> text of the license(s) in its own file, then that file, containing the text
> of the license(s) for the package must be included in %doc. If the source
> package does not include the text of the license(s), the packager should
> contact upstream and encourage them to correct this mistake.
> License seems indicated on slowstats.cc file.

http://code.google.com/p/slowhttptest/issues/detail?id=16&thanks=16&ts=1353075779

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to