Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878236

--- Comment #3 from Lorenzo Gil Sanchez <[email protected]> ---
Thanks a lot for this review!

I've updated the package with all your suggestions except the
CFLAGS="$RPM_OPT_FLAGS" thing. This package does not have any C extensions so I
think the CFLAGS are not needed. I guess the guidelines try to cover all cases
but this time is cleaner if we don't put that.

The update links:

Spec URL: http://lorenzogil.com/rpms/python-waitress/python-waitress.spec
SRPM URL:
http://lorenzogil.com/rpms/python-waitress/python-waitress-0.8.2-2.fc17.src.rpm

Koji builds:

 Fedora 17: http://koji.fedoraproject.org/koji/taskinfo?taskID=4723002
 Fedora 18: http://koji.fedoraproject.org/koji/taskinfo?taskID=4723006


rpmlint is much happier now :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to