Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=847504

Vít Ondruch <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |
              Flags|                            |fedora-review+

--- Comment #22 from Vít Ondruch <[email protected]> ---
Hi Miroslav,

* Test suite
  Could you please enable the test suite? I see no test error in Rawhide
  (except fixing BR: %{_bindir}/rspec to BR: rubygem(rspec)

* Move files not needed for runtime into -doc
  - I would say that the following items might go into -doc subpackage:

    %{gem_instdir}/init.rb
    %{gem_instdir}/tasks

BTW the RHEL macros, it seems that  you are missing %{gem_libdir} definition.

I APPROVE the package, however, please fix the two issues mentioned above prior
importing the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to