Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878243
--- Comment #3 from Vít Ondruch <[email protected]> --- * Wrong license - The LICENSE file states MIT. Please fix the license * Remove "Requires: ruby" - Since we are going to have better integration with JRuby in F19, this would force the dependency on MRI, while it should work with JRuby as well. * compass-rails is incompatible with compass in Fedora - Testing with F19: $ cd compass-rails-1.0.3/ $ ruby -Ilib -e 'require "compass-rails"' /compass-rails-1.0.3/lib/compass-rails.rb:228:in `<top (required)>': undefined method `register' for Compass::AppIntegration:Module (NoMethodError) from /usr/share/rubygems/rubygems/custom_require.rb:36:in `require' from /usr/share/rubygems/rubygems/custom_require.rb:36:in `require' from -e:1:in `<main>' * Test suite does not passes - It is executed, but 0 tests is executed, since they fail on missing dependencies. You need to add "BuildRequires: rubygem(compass)" at least, but then you'll be bitten by the incompatibility with rubygem-compass mentioned above. - I would suggest to use rubygem(minitest) for testing instead of rubygem(test-unit), if possible. - It seems that the tests depends on Bundler. It will be needed to get rid of it I guess. * Move file not needed for runtime into -doc subpackage - Following files are not needed by runtime IMO %{gem_instdir}/Appraisals %{gem_instdir}/Gemfile %{gem_instdir}/Guardfile Please consider to move them into -doc subpackage. - I would move the %doc %{gem_instdir}/README.md into -doc as well, but I'll keep it up to you. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
