Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=583869 Rahul Sundaram <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Rahul Sundaram <[email protected]> 2010-04-20 01:07:14 EDT --- [ Assuming you are only interested in maintaining this for Fedora 13 and above] You don't have to define the Python macros on top. They are done automatically by RPM itself in Fedora 13. Read the Fedora Python packaging guidelines carefully. https://fedoraproject.org/wiki/Packaging:Python You should also inquire with upstream about the Python 3 status of this module You can remove the buildroot definition and cleaning of buildroot in %install section. These are not necessary anymore. Also remove the commented out %clean section You should also add a comment on each of the patches with a short description of what it does and upstream status of the patches. Of course, you haven't filed it upstream or informed the upstream developer yet of these changes, now would be a good time to do so. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
