Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885833
--- Comment #15 from Rex Dieter <[email protected]> --- naming: ok sources: ok md5sum *.bz2 8e0a7c167e357c860601b5348469ad15 tw-0.9.4.tar.bz2 license: close, but... licensecheck -r src src/tw.in.sh: GPL (v3 or later) src/tw_mythes.sh: GPL (v3 or later) src/cmd.sh: GPL (v3 or later) src/mythes.cxx: *No copyright* UNKNOWN src/engines/tw_cache.sh: GPL (v3 or later) src/engines/tw_ft.sh: GPL (v3 or later) src/engines/tw_share.sh: GPL (v3 or later) src/engines/tw_yb.sh: GPL (v3 or later) src/engines/tw_local.sh: GPL (v3 or later) src/engines/tw_gt.sh: GPL (v3 or later) 1. MUST: Seems we can use License: GPLv3+ here 2. SHOULD consider omitting deprecated stuff from .spec like BuildRoot: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#BuildRoot_tag Group: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Group_tag %clean: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#.25clean %defattr: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_Permissions scriptlets: ok macros: ok dependencies: NOT ok 3. MUST: hrm, I can't find it explicitly in the guidelines at the moment, but pretty sure you can safely omit: Requires: glibc-common which is already implicitly pulled in by pretty much everything already. Being not a complicated package, the rest looks good, please look over items 1-3. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pTtdI7jKhV&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
