Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785480

--- Comment #8 from Shawn Iwinski <[email protected]> ---
(In reply to comment #7)


===== MUST items =====

[!]: Requires correct, justified where necessary.

According to phpci report (and "Horde/Log/Formatter/Xml.php" source), requires
"php-dom"


===== SHOULD items =====

[!]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.


===== COULD items =====

* Localized php.ini not necessary (also note that you not create it in %prep
for use in %install)
* In %files, "%{pear_testdir}/Horde_Log" could be changed to
"%{pear_testdir}/%{pear_name}"
* Require the following virtual packages: php-date, php-pcre, php-reflection,
php-spl
* When adding tests in %check in the future, add the require virtual packages
above along with the following: php-simplexml, php-libxml

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Af9rFr0eur&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to