Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=887611

Matthias Runge <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #2 from Matthias Runge <[email protected]> ---
Some drive-by notes:
- rm -rf $RPM_BUILD_ROOT at the beginning of %install is not required anymore
- no need for %defattr(-,root,root,-) in %files anymore
- clean section is also not required anymore
https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean

- several files in lib/platform carry this copyright notice:
This file is part of the libCEC(R) library.
It looks like, they were copied from somewhere else. You need to unbundle
those.

https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries

- Also: 
project/BuildDependencies/bin carries compiled files from Windows (dlls, exe
file)
You need to remove that during prep.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=tGtBjaWPkS&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to