Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=888301

--- Comment #13 from Antonio Trande <[email protected]> ---
(In reply to comment #9)

Hi Mario.

> Oops mid-air collision!! :)
> 
> Hi again, some miscellaneous findings before a more through review:
> 
> * There are at least two licenses: MIT (OrthancCppClient) and GPLv3. This
> should be reflected in the SPEC file as in:
> https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/
> LicensingGuidelines#Multiple_Licensing_Scenarios
> 

The licenses issue have already been bring up (see comment #3). :)   

Hi Michael

>> * An automated build attempt in Plague/Mock here failed:
>> ...
>> make[2]: python: Command not found
>> make[2]: Leaving directory `/builddir/build/BUILD/Orthanc-0.4.0'
>> 
>> Note that you could submit a scratch build in the Fedora Build System:
>> 
>> https://fedoraproject.org/wiki/
>> Join_the_package_collection_maintainers#Install_the_client_tools_.28Koji.
>> 29_and_set_up_your_certificate

>Mmmm... strange, I just mocked it and it worked... let's try with a scratch 
>>build!

For me too ...

>> %doc %{_mandir}/man1/*.1*

>Hint: %_mandir is marked %doc automatically.

I was uncertain about this line. Is it harmful for the package's building ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=pvsb2hi8A8&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to