Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=823333
--- Comment #2 from Julian C. Dunn <jd...@aquezada.com> ---
(In reply to comment #1)
> * Remove Requires: ruby for other Ruby interpretations to be used with in f19
>
> * Rakefile, NOTICE and README.rdoc are not require during runtime
> - Please consider moving them into the -doc subpackage
>
> * Please consider moving specs into the -doc subpackage rather than exclude
> them
>
> * I would suggest you to exclude %{gem_cache} as it's not needed
All of the above have been corrected.
> * Tests print:
>
> ........You must supply -r!
> Usage: /usr/local/bin/rspec (options)
> -r
> ......
>
> - Tests shouldn't print STDOUT like this. It could be fixed by something
> suggested on stackoverflow [1].
I added a patch for this to the SRPM, though I don't know if it'll be accepted
upstream -- it's a matter of taste and the fix is kind of dirty. But it will
silence output to STDOUT on the tests.
Please have a look:
http://jdunn.fedorapeople.org/rubygem-mixlib-cli/rubygem-mixlib-cli.spec
http://jdunn.fedorapeople.org/rubygem-mixlib-cli/rubygem-mixlib-cli-1.2.2-2.fc19.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=8JPnbVnrtT&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
