Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823332
Josef Stribny <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #3 from Josef Stribny <[email protected]> --- Thank you Julian. * There is no need to exclude %{gem_instdir}/spec if you are listing it later in %files doc. -- Leave the file in the %files doc section and remove the exclusion of the file in %files * Files README.rdoc and NOTICE could be probably placed in the -doc subpackage as they are not needed for runtime. -- Please consider moving them to the -doc subpackage * Additionally, you can consider keeping Rakefile in the -doc subpackage as well. Otherwise it looks good. Rpmlint gave me no errors and the package builds in Koji so I am APPROVING the package. Please fix the issues before pushing. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FWyDiE7xOy&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
