Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836368
Vít Ondruch <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #12 from Vít Ondruch <[email protected]> --- A few minor nits from my side: * Run test suite in %{gem_instdir} - We typically run test suite inside %{gem_instdir}, but it should not be of much importance here * Keep the Gemfile*, Rakefile and tests - I would suggest yout to keep the abovementioned files in -doc subpackage. Although they make not much sense in the Gem, I would keep them in Fedoras packages, since upstream ships them. Or on the contrary, ask upstream to remove them from the package. * Don't mark Rakefile by %doc macro - Rakefile is definitely not a document and should not be prepended by %doc macro -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ghmzyBATo2&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
