Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=773346
--- Comment #4 from Mamoru TASAKA <[email protected]> --- For 1.3-1 * No longer needed bits - "BuildRoot: %{_tmppath}..." line, "rm -rf $RPM_BUILD_ROOT" at the beginning of %install, the whole %clean section are no longer needed (on Fedora 19/18/17 and RHEL6: RHEL5 still need these item) https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean ? Installed pkgconfig file - As this binary rpm seems somewhat meant for development purpose, I don't make it a blocker that pkgconfig file is included in the main package. However looking at installed pkgconfig file, it seems essentially empty (it contains some basic information and does not contain Libs or Cflags information). Is this pkgconfig file really needed? * Executing tests - As this package contains test/ directory and test/run-test.sh script, please enable %check section and execute some test program if possible. * isa specific dependency - I don't know on which branches (may be EPEL5?) isa is not defined, however currently it is best to use %{?isa} instead of %{isa} (where isa may not be defined) ! Also please check the above "Installed pkgconfig file" section. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rQPJI5CML0&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
