Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891238
Michael Scherer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Depends On| |891190, 891195, 891181, | |891231 Assignee|[email protected] |[email protected] --- Comment #1 from Michael Scherer <[email protected]> --- Hi, so first, nice to have npm deps being in place in rpm, much easier :) A few notes : 1) %defattr(-,root,root,-) BuildRoot, and cleaning of root before %install and %clean are not needed, can you remove them ? 2) %check is not used ( this would need a few package, tap and rimram, both added as deps on this bugs ) 3) could the summary be improved a little :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iwBWkfNLGV&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
