Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=875150

Honza Horak <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
              Flags|                            |needinfo?([email protected])

--- Comment #16 from Honza Horak <[email protected]> ---
(In reply to comment #13)
> [!]: Changelog in prescribed format.
> 5.5.28-4 -> 5.5.28a-4
> 
> [!]: License field in the package spec file matches the actual license.
> Looking at the README and the result of fedora-review's licensecheck
> (will attach) it seems there could be also LGPLv2 and/or BSD licensed files.
> Could you check it ?
> 
> [!]: Final provides and requires are sane.
> I think you should remove all occurrences of %{epoch}, because it's
> undefined:
> # rpm -qp --provides mariadb-5.5.28a-4.fc18.x86_64.rpm 
> mysql = %{epoch}:5.5.28a-4.fc18

These are mistakes -- I'll fix them in the next round.

> [!]: %check is present and all tests pass.
> Shouldn't the tests be run in %check instead of %build ?

Tom, do you remember if there is a reason to run the tests in %build section?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=TS6yQqpP8I&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to