Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=870978
Michael Schwendt <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #8 from Michael Schwendt <[email protected]> --- I'd thought I might find a bit of time and fix the libcdio broken dep for Audacious before Mon/Tue, but upon taking a look at how to handle this new build requirement, I've run into this: $ rpmls -p libcdio-paranoia-devel-10.2+0.90-5.fc19.x86_64.rpm|grep inc -rw-r--r-- /usr/include/cdio/cdda.h drwxr-xr-x /usr/include/cdio/paranoia -rw-r--r-- /usr/include/cdio/paranoia.h -rw-r--r-- /usr/include/cdio/paranoia/cdda.h -rw-r--r-- /usr/include/cdio/paranoia/paranoia.h Why are there copies of the headers in two locations? The spec doesn't tell: > # fix wrong installation of header files > sed -i -e "s,includedir)/cdio,includedir)/cdio/paranoia,g" > include/cdio/paranoia/Makefile.in There are two more mistakes which should have been caught during review: > %package devel > Requires: %{name} = %{version}-%{release} https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package > # another multilib fix; remove the architecture information from version.h > sed -i -e "s,%{version}.*$,%{version}\\\",g" include/cdio/paranoia/version.h ??? This file is not installed, not packaged, not used. Btw, if the expression didn't match, nothing would be substituted either, the "fix" would be missing. For sed substitutions like this you ought to add a guard to the spec file (e.g. via grep), or use a patch instead. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WCcYOmVmT8&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
