Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890872
Miro Hrončok <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?([email protected] | |om) | --- Comment #6 from Miro Hrončok <[email protected]> --- (In reply to comment #5) Thanks for the review. > [!]: Large documentation must go in a -doc subpackage. > Note: Documentation size is 1075200 bytes in 8 files. > See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation Will look at that. > [!]: BSD license is indicated in addition to the primary MIT license, but no > comment is provided indicating what is under this license. I found that more complicated, so I just dropped this comment: # See License.txt for more information Isn't that enough? > [%]: There is no %check section. If upstream provides test cases, consider > adding them. If tests cannot be run in koji (e.g. since this requires > graphics), consider documenting that fact in the spec file. I cannot find any test, do you see them? Thanks. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VWm9WYxSJy&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
