Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896193
Mario Blättermann <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] | |m --- Comment #2 from Mario Blättermann <[email protected]> --- Some initial issues: It is not needed to extract the configure macro. Just put autogen.sh before running %configure. %{_datadir}/icons/gnome/16x16/apps/%{name}.svg %{_datadir}/icons/gnome/22x22/apps/%{name}.svg %{_datadir}/icons/gnome/24x24/apps/%{name}.svg %{_datadir}/icons/gnome/32x32/apps/%{name}.svg %{_datadir}/icons/gnome/48x48/apps/%{name}.svg %{_datadir}/icons/gnome/64x64/apps/%{name}.svg %{_datadir}/icons/gnome/128x128/apps/%{name}.svg %{_datadir}/icons/hicolor/16x16/apps/%{name}.svg %{_datadir}/icons/hicolor/22x22/apps/%{name}.svg %{_datadir}/icons/hicolor/24x24/apps/%{name}.svg %{_datadir}/icons/hicolor/32x32/apps/%{name}.svg %{_datadir}/icons/hicolor/48x48/apps/%{name}.svg %{_datadir}/icons/hicolor/64x64/apps/%{name}.svg %{_datadir}/icons/hicolor/128x128/apps/%{name}.svg You could shrink this as follows: %{_datadir}/icons/gnome/*/apps/%{name}.svg %{_datadir}/icons/hicolor/*/apps/%{name}.svg BuildRequires: desktop-file-utils This is fine, but the desktop file needs to be installed explicitely or at least validated: http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database The latter is probably not applicable because the desktop file doesn't introduce new MIME types. %clean rm -rf %{buildroot} Drop the %clean section. It is only needed for EPEL 5 packages. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oDLt0Hz44X&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
