Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901496
Mathieu Bridon <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW --- Comment #5 from Mathieu Bridon <[email protected]> --- (In reply to comment #4) > Ok, using > http://bochecha.fedorapeople.org/packages/perl-Email-Received-1.00-1.fc18. > src.rpm :) > > As usually, missing BRs :) > perl(base) > perl(constant) > perl(Exporter) > perl(Test) > perl(Test::More) Added. > You can substitute the %{__perl} macro with simple 'perl'. (lines 17 and 31; > optional) Substituted. > Also, Fedora Guidelines recommend using US English in Summary and > Description. Consider replacing 'analysing' with 'analyzing'. Replaced. /me wasn't even aware the word had a different spelling in en_GB and en_US :) > Switch from PERL_INSTALL_ROOT to DESTDIR unless you have your reasons not to. Switched. > The rest is okay. No other issues. Here's the new package. Spec URL: http://bochecha.fedorapeople.org/packages/perl-Email-Received.spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Email-Received-1.00-2.fc18.noarch.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OV0UiknOZP&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
