Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=903732

--- Comment #2 from Richard Shaw <[email protected]> ---
(In reply to comment #1)
> Hi Richard, I'll take this one.

Thanks!


> Real quick off the bat, are you planning to build this for EL5?  If not, I
> think the python_site* macros are already provided by EL6 and Fedora.

Yeah, those can go. I used rpmdev-newspec for the template which still has the
macros so I didn't bother to remove them.


> How did you find the v0.4 tarball archive?  I guess that's the most recent
> release?  I've got a specfile for master if it looks interesting; it's more
> complicated, with arch-specific binary RPMs linking numpy, and more BRs and
> Rs.  Might not be stable yet.

I just went to the github page and downloaded the latest tag there. If it's
sufficient for FreeCAD I'm not too worried about packaging master.


> I can add a %check script in there, but if it's like 0.5, it'll need a small
> patch to disable downloading dependencies.

0.4 doesn't download anything currently using the standard python setup.py
method.


> Looks good, pretty cookie-cutter.  I'll take a closer look in a day or two.

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=9U7MPLjHpJ&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to