Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=894725

--- Comment #17 from T.C. Hollingsworth <[email protected]> ---
(In reply to comment #16)
> I am afraid that the -common package does not contain the uglifyjs
> executable, so it is worthless for rubygem-uglifier purposes.

I can probably accommodate this, but I can't figure out where rubygem-uglifier
actually uses it.  It doesn't appear to bundle it.  If you can point me to Ruby
code that calls it in, that would be helpful.

> Moreover, the uglifier gem contains just single uglify.js file, which
> probably contains all the uglifyjs files. Not sure how to cope with that. If
> linking will be enough.

Looking at the Rakefile [1], it seems that it bundles source-map and uglify-js
by compiling them both into one .js file.  There is no bundled libraries
exception for JavaScript not in the browser, so I don't think this is
permissible in Fedora.  rubygem-uglifier will have to be patched to bring in
source-map and uglify-js separately.

I can, however, ship a minified version of uglify-js like rubygem-uglifier
wants, though I'm not sure why it's necessary.  The whole point of minification
is to reduce JS loading time in the browser; it's completely unnecessary
server-side.

[1] https://github.com/lautis/uglifier/blob/master/Rakefile

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=FUnJiLS6nz&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to