Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906255
Mamoru TASAKA <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|[email protected] |[email protected] Flags| |fedora-review? --- Comment #2 from Mamoru TASAKA <[email protected]> --- (In reply to comment #1) > Note that I am using ibus-1.5.1-2.fc19.i686 and using LXDE. Well, ? License (not a blocker) - Well, the license tag is correct with "GPLv2+" for this srpm, however actually GPLv3 license text is included int the source tarball (again still the license tag should be GPLv2+). Is this what you intended (as you are the upstream)? * Keeping timestamp - It is preferred to add "INSTALL='install -p'" to %make_install to keep timestamps on some files included in the binary rpm. ? Empty file (not a blocker) - Currently the included file "README" is empty, which is useless (since you are the upstream, I guess you are to write something on README later). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sUKbQf8Pv9&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
