Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=585719 --- Comment #2 from Alain PORTAL <[email protected]> 2010-04-26 14:56:43 EDT --- (In reply to comment #1) > Just a few comments: > > - You need to write in the specfile, how you got the sources and not 'I did > something and here they are'. > > e.g. there is a nice snipped /usr/bin/fedora-getsvn, maybe that's the > easiest > way: > 'fedora-getsvn wxformbuilder $URL-TOSVN $REV' I can't use fedora-getsvn because I can't set the current version, but I added some infos on how to get the packaged revision. > - You could do %{__mkdir} -p > %{buildroot}%{_datadir}/icons/hicolor/48x48/mimetypes > Instead all the mkdirs above Done > - You should not use a vendor tag: > > https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage > Done Spec URL: http://dionysos.fedorapeople.org/SPECS/wxformbuilder.spec SRPM URL: http://dionysos.fedorapeople.org/SRPMS/wxformbuilder-3.1.68-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
