Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=907756

--- Comment #10 from Sandro Mathys <[email protected]> ---
(In reply to comment #1)
> some drive by comments:
> 
> - there's no need to define a buildroot, please drop that
> 
> - please remove 
> rm -rf $RPM_BUILD_ROOT
>  from the beginning of install section
> 
> - please remove the clean section

What repos do you plan to submit this package for? While the above is necessary
for Fedora and EPEL 6, it would break compatibility to EPEL 5. Just saying. :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=nXBd3LpCya&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to