Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886903

--- Comment #28 from Simone Caronni <[email protected]> ---
Another issue:

Line 231: %{_bindir}/xonotic-dedicated

Should be in the "%files server" section.

Regarding d0_(In reply to comment #22)
> Addressed the above, left opengl-games-utils in place, haven't dealt with
> d0_blind yet. I can't use the paths above, as I'm not installing it.  It
> can't find all the static libs, they don't seem to be building.  I've left
> in what I have, commented out.

I'm looking into it, if I find anything new I'll write it here (it can always
be added later when the package is already approved, btw).

 > Not sure how to "unbundle" darkplaces, I've though about it and I don't
> think it's needed or appropriate.

I agree with you, but what about removing the darplaces* stuff entirely? I
don't see the benefit at all of having the default darkplaces engine the one
used in xonotic for the whole distribution.

I would remove all the darkplaces packages and package only the xonotic
binaries. Just leave the 2 make command in place and then package only the
xonotic-* binaries forgetting about the rest.

This way another darkplace based game can be imported in Fedora. And for
running quake, one could post for review the standalone darkplaces engine.

I think this way the package is much more cleaner and simple and does not block
anything else from going into fedora.

> Can't find an appropriate xonotic icon.

Could you please use the icons in comment #23?

Thanks,
--Simone

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=tYJSyz7O6Q&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to