Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910125
--- Comment #2 from Jamie Nguyen <[email protected]> --- Thanks for the review! [!]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. According to package.json "urun" is needed by the tests. Added. [!]: Package contains no bundled libraries. There is a copy of the "gently" npm as node-gently in the upstream source. It's not actually installed, but it may be best to remove it in %setup to be on the safe side. I'm not sure this is really necessary. All Node.js packages install files manually in %install. But I suppose it's probably best practice. Spec URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/nodejs-formidable.spec SRPM URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/SRPMS/nodejs-formidable-1.0.11-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RIi3NGppGT&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
