Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911188
--- Comment #2 from Jamie Nguyen <[email protected]> --- Created attachment 702051 --> https://bugzilla.redhat.com/attachment.cgi?id=702051&action=edit Difference between Node's eql and should's eql > [!]: Package contains no bundled libraries. > > It seems that lib/eql.js is (a) taken from node and also (b) the > same as what is in the deep-equal npm. The only problem is that it > was deliberately changed so that 4 and "4" are not equal: > > https://github.com/visionmedia/should.js/commit/09886401aba56f21a02796599c1c75301113b978 Hmm. I'm never really sure how to deal with things like this, but to me it seems like a fork. I've attached a diff of the functions involved and the changes are small but not insignificant. > [!]: Latest version is packaged. > > 1.2.2 has been released. Thanks, updated. > [!]: Rpmlint is run on all installed packages. > > nodejs-should.noarch: W: spelling-error %description -l en_US bevaviour -> > behavior Thanks, fixed. Spec URL: http://jamielinux.fedorapeople.org/mocha/nodejs-should.spec SRPM URL: http://jamielinux.fedorapeople.org/mocha/SRPMS/nodejs-should-1.2.2-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OsTA8MJAgt&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
