Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148
--- Comment #5 from Jamie Nguyen <[email protected]> --- > [!]: %check is present and all tests pass. > > I'm seeing 11 test failures when the tests are enabled. Hmm, indeed my notes seem to say the same. Sorry, I must have forgotten about this. Will try to fix. > [!]: Package complies to the Packaging Guidelines > > Per https://fedoraproject.org/wiki/Packaging:Node.js#Installing_Modules > the images should I believe be installed in %{_datadir}? Yes I believe you're right. > Also, should lib-cov be installed? It's just a copy of lib annotated > for coverage testing isn't it? Correct. I thought I'd removed that from all of my review requests. A grep of my specs seems to confirm this is the only case where I forgot! New Spec/SRPM coming soon. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PEIke9zs5A&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
