Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916665
--- Comment #2 from Tomas Mlcoch <[email protected]> --- Hi Michael, thank you for review. Fixed version: Spec URL: http://tmlcoch.fedorapeople.org/librepo.spec SRPM URL: http://tmlcoch.fedorapeople.org/librepo-0.0.1-2.20130307gitc69642e.fc17.src.rpm > > Version: 0.0.1 > > Release: 1.git%{gitrev}%{?dist} > https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages Fixed(?) > > License: GPLv2 > > That's odd, because several files in ./librepo claim GPLv2+. > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#. > 22or_later_version.22_licenses Fixed (Update license in spec to GPLv2+) > > Source0: librepo-%{gitrev}.tar.xz > > https://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control > https://fedoraproject.org/wiki/Packaging:SourceURL#Github Fixed(?). Librepo has its own "tarbaling" script so I add comment with command that generate the tarball: # Use the following commands to generate the tarball: # git clone https://github.com/Tojaj/librepo.git # cd librepo # utils/make_tarball.sh %{gitrev} > > %package devel > > Requires: %{name} = %{version}-%{release} > > https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package > (also applies to the python-librepo package base dependency) Fixed. Used fully versioned arch-specific dependency: Requires: %{name}%{?_isa} = %{version}-%{release} > > %package -n python-librepo > > Group: Development/Langueages Fixed > > %files devel > > %doc COPYING Fixed. Line removed. > > %files -n python-librepo > > %{python_sitearch}/ Fixed(?). I add librepo/ dir to the path: %files -n python-librepo %{python_sitearch}/librepo/ Comment on rpmlint warning about "This library package calls exit() ...": The exit() is called only when malloc() call fails. This is considered as very serious problem and there is no way to continue properly and safely and thus it is better to halt the program execution. (For example libsolv has the exactly same behaviour - https://github.com/openSUSE/libsolv/blob/master/src/util.c#L26). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=R3252Yc4Zt&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
