Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=919712

Pierre-YvesChibon <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review+

--- Comment #5 from Pierre-YvesChibon <[email protected]> ---
- License is valid but indeed your ticket is necessary since the setup.py is
the only place it is mentionned (no headers in the file).
- Spec is nice and clear just a few remarks:
  - you can drop the group
  - you can drop the modname macro since we're not using the prefix python-
here
- sha1sum:
  Source0 rpm: 0cddb508dea11b6fdc6698abf92df1949a51965a
  Upstream   : 0cddb508dea11b6fdc6698abf92df1949a51965a
- The project builds well on Fedora 18

Looks all good to me: APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=65RBmP413M&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to