Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882561
Rex Dieter <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|[email protected] | |project.org | Flags| |fedora-review? --- Comment #3 from Rex Dieter <[email protected]> --- OK, review time. naming: ok sources: ok 0b9a0fc9e9c3ff0134433a6ccca0885a mate-bluetooth-1.5.0.tar.xz licensing: ok (combined work of LGPLv2+ and GPLv2+ sources) builds/installs: ok dependencies: NOT ok 1. MUST remove Requires: desktop-file-utils (this is really not wanted or needed at runtime) 2. SHOULD move NOCONFIGURE=1 ./autogen.sh to %prep section 3. scriptlets: NOT ok MUST add missing icon-cache scriptlets 4. SHOULD consider -libs subpkg, for %{_libdir}/libmate-bluetooth.so.8* , else main package will get multilib'd too 5. SHOULD build with options: --disable-desktop-update then you can drop %exclude %{_datadir}/applications/mimeinfo.cache 6. SHOULD drop extraneous %configure option: --with-gnu-ld that is, unless you can document some need for it? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cKyALcEmHJ&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
