Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836840
Hans de Goede <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #13 from Hans de Goede <[email protected]> --- Hi All, Bebo has send a mail about this package to the Fedora-games mailinglist I think it is useful to reproduce my reply to his mail here: I've taken a quick look at your gtkradiant packages, but as already indicated by both Jason and Michael in this bug, your package as is, is no good. I'm sorry to say so, but it is no good at all. You cannot create package for a FOSS distro such as Fedora by using precompiled binaries from upstream and putting those in an rpm. If you look at other spec files in Fedora you will see they all start with the C source code, then compile and install this, ie: %build %configure make %install make install DESTDIR=$RPM_BUILD_ROOT Rather then using prebuild binaries, using prebuild binaries simple is not acceptable within Fedora. So what you need to do is get the sources and use those as Source0, since the sources are on github, and they're not tagging releases just take a git-snapshot .zip file as Source0 by clicking on the zip button here: https://github.com/TTimo/GtkRadiant This means that your Source0 won't have a url and rpmlint will complain, but that is ok. Simple add a comment above the Source0 tag to explain where the sources come from. But I see that gtkradiant also uses scons as a buildsystem, which is a pain to work with. Since you're new to packaging it would likely be better to choose a different package as your first Fedora packages. Sorry I could not be more helpful. Regards, Hans -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cTMEFbNj71&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
