Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907007
Michael Schwendt <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #12 from Michael Schwendt <[email protected]> --- > I do not expect any Fedora-shipped program to link to this library, > as it is used for unit testing only, so mandating a soname seems overkill Then building a shared lib and two packages seems overkill, too. Why don't you simply build just the static lib as upstream does it? Package unittest++-devel with a virtual unittest++-static to meet the guidelines: https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries_2 Or build the shared lib but move _all_ files into a single unittest++-devel package together with the headers and the ldconfig calls. Instead, you treat the shared lib like a full system run-time lib in its separate run-time package. What is the benefit, if you expect no Fedora package to depend on the shared lib? > CPPFLAGS='%{optflags}' make %{?_smp_mflags} The source doesn't use $CPPFLAGS but $CXXFLAGS - and your patch adds $CFLAGS. Due to that it doesn't adhere to the %optflags guidelines either: https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags To see what is being built with, you would need to make the build output less silent and e.g. patch the command invocations in the Makefile. > %package devel > Summary: Object files for development using unittest-cpp Decide on either name. Either unittest++ (like the project name) or unittest-cpp (like the upstream source zip). * Run "rpmlint -i" on the src.rpm and all built rpms. Some of the reported warnings/errors may be dubious (false positives), however. Be aware of that. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Yp78cS0I9b&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
