Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907076
--- Comment #9 from Kevin Kofler <[email protected]> --- There's still stuff that needs fixing: * I think default.jconf needs to go away entirely, even from the tarball. * License of -doc should be GFDL. * I don't like how libeventsimulation.so is 1. unversioned and 2. has a generic, non-Simon-specific name. At least fedora-review frowns on unversioned libraries, though AIUI they're not banned by the guidelines. I'm going to upload a small CMakeLists.txt patch which should make it look like the other Simon-internal libraries. I checked some of the other stuff: * simon.log seems to be a leftover from old removed logging code: http://lists.kde.org/?l=kde-commits&m=135629045204988 (I can't find any reference to it in the current code.) so removing it is right, we should ask upstream to drop the file. * The Voxforge license seems to only apply to content that can be downloaded (or uploaded) from Simon, not to anything in the Simon distribution itself, so listing it in License should not be necessary. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Lu37TOlCIf&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
