Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=920778

--- Comment #2 from Bohuslav "Slavek" Kabrda <[email protected]> ---
- I'd advise using %{version} in URL (instead of current 0.1.1).
- pushd/popd seem a bit cleaner than cd/cd -, but that's just my impression :)
- Files in %{python_sitelib} shouldn't be executable, IMHO. If these files
really need to be executed by user, I'd suggest placing some stub into
%{_bindir}. setuptools' entry_points should do the trick [1]. It might be worth
it to create pull request that would introduce usage of entry_points and send
it upstream.

[1]
http://pythonhosted.org/distribute/setuptools.html#dynamic-discovery-of-services-and-plugins

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=94D43VzPt2&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to