Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=922291
--- Comment #4 from Shawn Iwinski <[email protected]> --- (In reply to comment #3) > No real blocker, but please just answer a few questions before I approve > this package > > I will prefer you don't remove PropertyAccessorCustomArrayObjectTest.php > test script > but rather remove it only in %check The reason why I removed it is because that is the only file causing a circular dependency with the Form component -- it requires one of the Form component's tests [1]. Also, it seems to be an empty test and only caused issues. I will only remove it in %check if you would like, but note that end-user tests will fail as well without having the Form component installed. [1] https://github.com/symfony/symfony/blob/master/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorCustomArrayObjectTest.php#L14 > Can't you use the upstream "autoloader.php" instead of building your ? > (well, it seems preferable to rely on include_path instead on this > stupid > file_exists) The supplied autoloader.php works fine in %check with the upstream directory structure, but does not work when PEAR-installed and the tests are in a new location. End-user tests would fail if the custom autoloader was not created and used. > Why do you edit the phpunit.xml.dist and not simply create a > phpunit.xml and add it to the package? No real valid reason why other than allowing the end-user to create their own and keeping the ".dist" as the en-user point-of-view distributed version. I can update the spec to use what you describe. > Are .git* files, and role issue reported upstream ? > (please add a link to upstream bug) I forgot to do that earlier. I just did though... https://github.com/symfony/symfony/issues/7414 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=doSe0PgEKb&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
