Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=874905

Peter Borsa <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+

--- Comment #25 from Peter Borsa <[email protected]> ---
Good:

- rpmlint checks return:

$ rpmlint php-drush-drush.spec ../SRPMS/php-drush-drush-5.8.0-2.fc18.src.rpm
../RPMS/noarch/php-drush-drush-5.8.0-2.fc18.noarch.rpm

php-drush-drush.src: W: spelling-error %description -l en_US sql -> sq, sol, sq
l
php-drush-drush.src: W: spelling-error %description -l en_US cron -> corn, con,
crone
php-drush-drush.noarch: W: spelling-error %description -l en_US cron -> corn,
con, crone
2 packages and 1 specfiles checked; 0 errors, 3 warnings.

- package meets naming guidelines
- package meets packaging guidelines
- license ( GPLv2+ ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream

$ md5sum drush-5.8.0.tgz ; curl -s -o -
http://pear.drush.org/get/drush-5.8.0.tgz | md5sum -
00d01f69bbd356245cf608a3a81d99e6  drush-5.8.0.tgz
00d01f69bbd356245cf608a3a81d99e6  -

- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=sQrTV9FTQu&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to