Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906411
Tom "spot" Callaway <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #5 from Tom "spot" Callaway <[email protected]> --- A few quick things before I review and sponsor: This spec file has a lot of old RPM anachronisms that aren't used anymore in Fedora, specifically: * BuildRoot does not need to be set (it is ignored) * rm -rf %{buildroot} does not need to be run at the beginning of %install (this is done automatically) * There is no need to define a %clean section if you're just putting in rm -rf %{buildroot}, this is the automatic default, just remove the %clean section entirely. * %defattr(-,root,root) is the default, you do not need to state it. Unless you're planning on maintaining mup in EPEL, please remove all these items. I also think it is a lot cleaner for that mupmate.desktop file to be an actual Source1 file, rather than written out from the spec. Just do: Source1: mupmate.desktop then mkdir -p %{buildroot}/%{_datadir}/applications cp %{SOURCE1} %{buildroot}/%{_datadir}/applications/ desktop-file-validate %{buildroot}/%{_datadir}/applications/mupmate.desktop Everything else seems okay, fixup those issues and i'll finish off the final review and sponsor you. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5T5AawgoOA&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
