Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=812561

Haïkel Guémar <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
              Flags|needinfo?                   |

--- Comment #8 from Haïkel Guémar <[email protected]> ---
* upstream provides a 0.7 tarball on PyPI, please update your package
accordingly
* unless you plan to maintain EPEL5 branch, no need of defining buildroot or
cleaning it
* please fix the with_python3 conditional as expressed in guidelines
https://fedoraproject.org/wiki/Packaging:Python#Example_spec_file
http://lists.fedoraproject.org/pipermail/python-devel/2012-July/000407.html
* drop %defattr macro, it's no more required for RPM >= 4.4.x (includes EPEL5)
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_Permissions
* since it's noarch, drop the CFLAGS
* packages installs and works fine

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=HoeSP0sY4m&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to