Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908594
Tomas Radej <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #9 from Tomas Radej <[email protected]> --- I can't object to the conditional build solution you chose, but I personally would go with different SPECs for rawhide/F19+ and F18-. The SPEC is okay apart from mixing Requires and BuildRequires. They should be in separate, non-overlapping groups. I am, though, trusting you to fix this before you upload. Additional notes: * Group tag is not necessary, so unless you intend to support EPEL, you may omit it. * BuildRequires on jpackage-utils is not necessary for maven packages, it's automatically required by maven-local. *** APPROVED *** -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=T9IGcSuJb3&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
