Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948345
--- Comment #4 from Colin Walters <[email protected]> --- (In reply to comment #3) > > > Does it really need ncurses/readline headers? I couldn't find any > > > ncurses/readline includes in the js header files, at least. > > Just to clarify, I wasn't talking about BuildRequires. I was talking about > the -devel package's runtime requires on the ncurses/readline headers. The > dependency seemed to indicate that the ncurses/readline headers need to be > present to use the installed js public headers. I was just objecting to that > and saying that the public headers (in the -devel package) don't appear to > include anything else besides glibc headers. Ah, yes; that looks right. > > Looks like it has an internal copy of editline =/ > > > > I will work on de-bundling this. > > Cool! This was easier than I thought, there's a --enable-readline we weren't passing. > If you want to avoid shipping the js17 executable in any case, then it > doesn't really matter for Fedora if the tarball has an internal editline or > not. If we remove the binary, we aren't shipping the statically linked > internal copy anyway. I decided to ship it for now for testing purposes; the static linking issue is annoying but I need to learn their funky build system in order to fix it. One other note, I just saw it bundles libffi, but it's not actually built becuase we're not enabling ctypes. It's now deleted in %prep too. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=w1kk8VajUe&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
