Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=946968
--- Comment #3 from Mamoru TASAKA <[email protected]> --- (In reply to comment #2) > 1. Please - separate spec sections other then expressions inside them - e.g. > with double CR. It's too hard to read spec now. Well, even if I add one more new line between section, after review passed I again cut such extra line... (I agree that at least one line is needed between sections, but "two" lines are just redundant) > 2. maybe to add -DCMAKE_BUILD_TYPE=Release to %cmake will be better > (https://bugzilla.redhat.com/show_bug.cgi?id=919044#c22) May consider afterwards. I will wait for full reviews to see what are real blockers, thank you. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wdLgRped2N&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
