Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=893866
--- Comment #22 from Peter Robinson <[email protected]> --- Some initial feedback: Because it's only ARM and x86 the ExcludeArch should be: ExclusiveArch: %{ix86} x86_64 %{arm} You also need to put as comments the exact commands used to generate the source tar file and record either the tag or the git ID used for the build as per these guidelines: http://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control It also needs a %description field. For patch lines I tend to do the following primarily for readability: %patch0 -p0 -b .nostatic %patch1 -p0 -b .fixprintf Rest of the review in progress. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jra1865ZlX&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
