Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=947640
Michael Scherer <m...@zarb.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m...@zarb.org
--- Comment #2 from Michael Scherer <m...@zarb.org> ---
Hi, a few comment :
- I personnally find that Requires and BuildRequires are more readable if there
is one per line, especially since this is cleaner when reviewing diff.
- Requires:
gstreamer1,clutter,clutter-gtk,gstreamer1-plugins-base,clutter-gst,gtk3
gtk3, gstreamer1 and clutter are likely already pulled by rpm automated library
dependency. And gstreamer1-plugins-base is likely pulled already. Can you clean
the Requires from redundant rpm ?
- why is autoreconf -i run in %build ?
- as %post run /usr/bin/update-mime-database , shouldn't it requires
shared-mime-info as Requires(post) ? ( but I am not sure, since there is '||
:', I guess that should be checked by someone else.
- the same goes for /usr/bin/gtk-update-icon-cache ? ( especially since that's
a software in gtk2 rpm )
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=anRRZSoqrb&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
