Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949073
Colin Walters <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Colin Walters <[email protected]> --- I'm not finding many other standalone nagios plugins in Fedora. All that I see is the "nagios-plugins" katamari and a few subpackages of larger modules. The first thing that struck me as odd is: > tar xf agents.tar.gz It has tarballs in tarballs? I don't know whether this is normal for nagios agents or not. Now, the install section. At a high level, have you considered trying to do any of this upstream? Does it not have "make install DESTDIR=" support? If not, adding it there would reduce maintenance pain later. Not a blocker though. cat > %{buildroot}%{_datadir}/check_mk/modules/defaults <<'EOF' Hmm...some of this seems like it should be configurable by the system administrator of the package. But maybe that's already possible. Those are just some quick comments; this is a hard package for me to review because of my unfamiliarity with nagios and the lack of another similar package as a comparison base. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EZXj2zCpUs&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
